Split ArrayReaderBuilder into its own module (#1483) #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 24, 2022
| use super::*; | ||
|
|
||
| #[test] | ||
| fn test_create_array_reader() { |
There was a problem hiding this comment.
This is the only unit test of this functionality, created #1484 to track improving this along with potentially refactoring the code to be less monolithic
alamb
reviewed
Mar 24, 2022
| @@ -87,6 +75,8 @@ mod offset_buffer; | |||
| #[cfg(test)] | |||
| mod test_util; | |||
|
|
|||
| pub use builder::build_array_reader; | |||
There was a problem hiding this comment.
👍 for making this backwards compatible
alamb
approved these changes
Mar 24, 2022
yjshen
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1483.
Rationale for this change
See ticket
What changes are included in this PR?
This just moves some code around, no logic changes are performed.
Are there any user-facing changes?
No