Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Unit Test Coverage of ArrayReaderBuilder #1484

Closed
tustvold opened this issue Mar 24, 2022 · 1 comment · Fixed by #1682
Closed

Improve Unit Test Coverage of ArrayReaderBuilder #1484

tustvold opened this issue Mar 24, 2022 · 1 comment · Fixed by #1682
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Mar 24, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Whilst working on #1483 I noticed that ArrayReaderBuilder has a single rather limited unit test. Whilst I think many codepaths are covered by tests at higher levels, it would be good to have some unit test coverage of what is a relatively non-trivial piece of code which walks the potentially nested parquet schema.

It may also be a worthwhile exercise to split up the relatively large functions into smaller functions that can be tested independently, with the added bonus of improving readability.

Describe the solution you'd like

Some more unit tests of this functionality

@tustvold
Copy link
Contributor Author

#1682 greatly simplified this logic, moving it to be covered by the pre-existing schema test suite, and removed ArrayReaderBuilder.

#1698 tracks some additional improvements that could be made to further enhance the test coverage of the schema conversion logic, but I think #1682 can be considered closing this ticket

@alamb alamb added the parquet Changes to the parquet crate label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants