Remove existing has_ methods for optional fields in ColumnChunkMetaData
#1346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
Coverage 83.04% 83.04%
=======================================
Files 181 181
Lines 52937 52933 -4
=======================================
- Hits 43960 43957 -3
+ Misses 8977 8976 -1
Continue to review full report at Codecov.
|
| self.dictionary_page_offset().unwrap() | ||
| } else { | ||
| self.data_page_offset() | ||
| let col_start = match self.dictionary_page_offset() { |
There was a problem hiding this comment.
I don't think it matters at all, but just FYI you can also write this code like
let col_start = self.dictionary_page_offset()
.unwrap_or(self.data_page_offset())Which some might argue is more 'idomatic' rust
There was a problem hiding this comment.
Sorry for the delay - I was out last week. Would you like me to send a refactor for this? :)
There was a problem hiding this comment.
It is up to you -- I always like to keep the code clean and small PRs to make it better are easy to approve and merge. However, there are only so many hours in a day :)
(welcome back BTW 👋 )
|
Thanks again @shanisolomon |
alamb
changed the title
ColumnChunkMetaData
Which issue does this PR close?
Closes #1332.
Rationale for this change
This methods are redundant as the fields are Optional and could be matched.
Will break all current usages of these methods, but could could be easily refactored to:
if let Some(val) = metadata.page_index_offset{...}