-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant has_
methods in ColumnChunkMetaData
#1345
Remove redundant has_
methods in ColumnChunkMetaData
#1345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
- Coverage 83.04% 83.04% -0.01%
==========================================
Files 181 181
Lines 52937 52926 -11
==========================================
- Hits 43960 43950 -10
+ Misses 8977 8976 -1
Continue to review full report at Codecov.
|
This looks fine. I'm just not sure if it'll break some existing code depending on the crate though since they are public. |
@sunchao IIUC the methods were exposed part of v9.1 which hasn't been published yet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. Then LGTM.
@alamb Do you mind please assisting with merging? :) |
Merged, thanks @shanisolomon ! |
has_
methods in ColumnChunkMetaData
Sorry for the delay @shanisolomon -- I was out last week |
Since these functions were released in 9.1.0 removing them is technically a breaking change, so marking them as such |
Which issue does this PR close?
Closes #1344.
Rationale for this change
Remove redundant has_ methods for optional column metadata members as they could be access by
if let(Some) = field
.