Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant has_ methods in ColumnChunkMetaData #1345

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

shanisolomon
Copy link
Contributor

Which issue does this PR close?

Closes #1344.

Rationale for this change

Remove redundant has_ methods for optional column metadata members as they could be access by if let(Some) = field.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Feb 20, 2022
@shanisolomon shanisolomon changed the title Remove extended metadata has Remove redundant has_ methods for optional column metadata fields Feb 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1345 (6270107) into master (ecba7dc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   83.04%   83.04%   -0.01%     
==========================================
  Files         181      181              
  Lines       52937    52926      -11     
==========================================
- Hits        43960    43950      -10     
+ Misses       8977     8976       -1     
Impacted Files Coverage Δ
parquet/src/file/metadata.rs 93.88% <ø> (+0.43%) ⬆️
parquet/src/file/serialized_reader.rs 94.60% <ø> (-0.04%) ⬇️
arrow/src/datatypes/datatype.rs 66.40% <0.00%> (-0.40%) ⬇️
arrow/src/array/transform/mod.rs 84.39% <0.00%> (-0.14%) ⬇️
arrow/src/datatypes/field.rs 54.10% <0.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba7dc...6270107. Read the comment docs.

@sunchao
Copy link
Member

sunchao commented Feb 20, 2022

This looks fine. I'm just not sure if it'll break some existing code depending on the crate though since they are public.

@shanisolomon
Copy link
Contributor Author

@sunchao IIUC the methods were exposed part of v9.1 which hasn't been published yet?

Copy link
Member

@sunchao sunchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Then LGTM.

@shanisolomon
Copy link
Contributor Author

@alamb Do you mind please assisting with merging? :)

@sunchao sunchao merged commit a69f0d1 into apache:master Feb 22, 2022
@sunchao
Copy link
Member

sunchao commented Feb 22, 2022

Merged, thanks @shanisolomon !

@alamb alamb added the api-change Changes to the arrow API label Feb 28, 2022
@alamb alamb changed the title Remove redundant has_ methods for optional column metadata fields Remove redundant has_ methods in ColumnChunkMetaData Feb 28, 2022
@alamb
Copy link
Contributor

alamb commented Feb 28, 2022

Sorry for the delay @shanisolomon -- I was out last week

@alamb alamb added api-change Changes to the arrow API and removed api-change Changes to the arrow API labels Feb 28, 2022
@alamb
Copy link
Contributor

alamb commented Feb 28, 2022

Since these functions were released in 9.1.0 removing them is technically a breaking change, so marking them as such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant has_ methods for optional column metadata fields
4 participants