Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/driver/snowflake): add adbc_snowflake crate with Go driver wrapper #2207

Merged
merged 24 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7dd0c67
feat(rust/driver/snowflake): add `adbc_snowflake` crate with Go drive…
mbrobbel Oct 1, 2024
0ed54ab
Rename `rust/drivers` to `rust/driver`
mbrobbel Oct 1, 2024
ea19114
Add required permissions for `native-unix` workflow
mbrobbel Oct 1, 2024
691785a
Also add `contents: read` to permissions for `native-unix` workflow
mbrobbel Oct 1, 2024
a213419
Merge branch 'main' into rust/snowflake
mbrobbel Oct 8, 2024
88d8809
Merge branch 'main' into rust/snowflake
mbrobbel Oct 9, 2024
23b995f
Merge branch 'main' into rust/snowflake
mbrobbel Nov 14, 2024
b541e07
Also move `datafusion` to `driver`
mbrobbel Nov 14, 2024
277bbc9
Fix unused warning
mbrobbel Nov 14, 2024
4e6d9ce
Add configuration builders
mbrobbel Nov 19, 2024
e6f3638
Add missing license headers
mbrobbel Nov 19, 2024
b6e7cd1
Fix clippy warning
mbrobbel Nov 19, 2024
c686f2e
Add `bundled` and `linked` features to control linking
mbrobbel Nov 19, 2024
032cb92
Use testing database in CI
mbrobbel Nov 19, 2024
25a86c9
Merge branch 'main' into rust/snowflake
mbrobbel Nov 19, 2024
80898f1
Add go lib dir to search path
mbrobbel Nov 19, 2024
cf54213
Disable integration tests for now
mbrobbel Nov 19, 2024
7b3ed83
Ignore load dynamic driver test when `linked` feature is not set
mbrobbel Nov 20, 2024
af70f82
Set `ADBC_SNOWFLAKE_GO_LIB_DIR` for all steps
mbrobbel Nov 20, 2024
041f72d
Add `adbc_snowflake` to release script
mbrobbel Nov 20, 2024
0229b41
Add some get info methods and tests
mbrobbel Nov 20, 2024
2b5a8b9
Add a few more tests
mbrobbel Nov 20, 2024
61bc558
Add some docs
mbrobbel Nov 21, 2024
029ccae
Mark doctests that require a Snowflake account as `no_run`
mbrobbel Nov 21, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,15 @@ jobs:
run: |
rustup toolchain install stable --no-self-update
rustup default stable
- name: Get required Go version
run: |
(. ../.env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- uses: actions/setup-go@v5
with:
go-version: "${{ env.GO_VERSION }}"
check-latest: true
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Install Protoc
if: runner.os == 'Linux'
run: |
Expand Down Expand Up @@ -104,10 +113,16 @@ jobs:
if: matrix.os == 'macos-13'
run: |
echo "DYLD_LIBRARY_PATH=/usr/local/opt/sqlite/lib:${{ github.workspace }}/build/lib:$DYLD_LIBRARY_PATH" >> "$GITHUB_ENV"
- name: Set search dir for Snowflake Go lib
run: echo "ADBC_SNOWFLAKE_GO_LIB_DIR=${{ github.workspace }}/build/lib" >> "$GITHUB_ENV"
- name: Clippy
run: cargo clippy --workspace --all-targets --all-features -- -Dwarnings
- name: Test
run: cargo test --workspace --all-targets --all-features
# env:
# ADBC_SNOWFLAKE_TESTS: 1
# ADBC_SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
# ADBC_SNOWFLAKE_SQL_DB: ADBC_TESTING
- name: Doctests
run: cargo test --workspace --doc --all-features
- name: Check docs
Expand Down
4 changes: 3 additions & 1 deletion dev/release/post-08-rust.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ main() {

pushd "${SOURCE_TOP_DIR}/rust"
cargo publish --all-features -p adbc_core
cargo publish -p adbc_snowflake
popd

echo "Success! The released Cargo crate is available here:"
echo "Success! The released Cargo crates are available here:"
echo " https://crates.io/crates/adbc_core"
echo " https://crates.io/crates/adbc_snowflake"
}

main "$@"
Loading
Loading