feat(rust/driver/snowflake): add adbc_snowflake crate with Go driver wrapper
#2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Oct 11, 2024
zeroshade
reviewed
Oct 11, 2024
Comment on lines
+35
to
+56
| type Option = OptionConnection; | ||
|
|
||
| fn set_option(&mut self, key: Self::Option, value: OptionValue) -> Result<()> { | ||
| self.0.set_option(key, value) | ||
| } | ||
|
|
||
| fn get_option_string(&self, key: Self::Option) -> Result<String> { | ||
| self.0.get_option_string(key) | ||
| } | ||
|
|
||
| fn get_option_bytes(&self, key: Self::Option) -> Result<Vec<u8>> { | ||
| self.0.get_option_bytes(key) | ||
| } | ||
|
|
||
| fn get_option_int(&self, key: Self::Option) -> Result<i64> { | ||
| self.0.get_option_int(key) | ||
| } | ||
|
|
||
| fn get_option_double(&self, key: Self::Option) -> Result<f64> { | ||
| self.0.get_option_double(key) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not familiar enough with Rust, but can't these just be inherited somehow from a base type instead of having to implement them here?
There was a problem hiding this comment.
Yes, we should be using traits for this. Discussed before here: #1725 (comment).
I'll try to put up a PR to change these option structs to traits following the proposal in #1725 (comment).
|
Marking this ready for review. This already a big PR so maybe it's better to get some feedback now, and add more tests and docs in follow-up PRs. |
lidavidm
approved these changes
Nov 22, 2024
| let _ = dotenvy::dotenv(); | ||
|
|
||
| let use_high_precision = env::var(Self::USE_HIGH_PRECISION_ENV) | ||
| .ok() |
There was a problem hiding this comment.
Might it make more sense to report errors and return Result<Self>?
|
I re-ran CI. I'll merge this for now. Thanks @mbrobbel! |
lidavidm
pushed a commit
that referenced
this pull request
Nov 25, 2024
…nv` when parsing fails (#2334) As suggested in #2207 (comment) the `Builder::from_env` methods should return a result when parsing fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
adbc_snowflakecrate to the Rust workspace. This crate provides a Snowflake ADBC driver for Rust by wrapping the Go driver, loaded by the Rust driver manager implementation. Thebuild.rsscript builds the Go driver and links it statically.