-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: caller location error in logs #2367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2367 +/- ##
===========================================
- Coverage 68.52% 49.22% -19.31%
===========================================
Files 131 41 -90
Lines 3419 3171 -248
Branches 826 0 -826
===========================================
- Hits 2343 1561 -782
- Misses 1076 1411 +335
- Partials 0 199 +199
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case to cover it?
Refer: https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh
ok |
done! |
have a check, thx @bzp2010 |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
Related issues
fix/resolve #2365
Checklist: