Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caller location error in logs #2367

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: caller location error in logs #2367

merged 2 commits into from
Mar 16, 2022

Conversation

jwrookie
Copy link
Contributor

@jwrookie jwrookie commented Mar 8, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Please update this section with detailed description.

Related issues

fix/resolve #2365

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #2367 (3f0ae73) into master (561ed37) will decrease coverage by 19.30%.
The diff coverage is n/a.

❗ Current head 3f0ae73 differs from pull request most recent head 1c509ee. Consider uploading reports for the commit 1c509ee to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2367       +/-   ##
===========================================
- Coverage   68.52%   49.22%   -19.31%     
===========================================
  Files         131       41       -90     
  Lines        3419     3171      -248     
  Branches      826        0      -826     
===========================================
- Hits         2343     1561      -782     
- Misses       1076     1411      +335     
- Partials        0      199      +199     
Flag Coverage Δ
backend-unit-test 49.22% <ø> (?)
frontend-e2e-test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/components/Plugin/UI/basic-auth.tsx
web/src/components/Plugin/UI/plugin.tsx
web/src/components/PluginFlow/PluginFlow.tsx
...mponents/Upstream/components/active-check/Host.tsx
web/src/components/ActionBar/ActionBar.tsx
web/src/pages/PluginTemplate/components/Step1.tsx
web/src/components/RawDataEditor/RawDataEditor.tsx
...pages/Route/components/CreateStep4/CreateStep4.tsx
web/src/pages/Route/components/Step1/index.tsx
...omponents/passive-check/Unhealthy/HttpFailures.tsx
... and 162 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561ed37...1c509ee. Read the comment docs.

@starsz starsz requested review from bzp2010 and nic-chen and removed request for bzp2010 March 9, 2022 01:34
Copy link
Contributor

@starsz starsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwrookie
Copy link
Contributor Author

jwrookie commented Mar 9, 2022

Can you add a test case to cover it? Refer: https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh

ok

@jwrookie
Copy link
Contributor Author

jwrookie commented Mar 9, 2022

Can you add a test case to cover it? Refer: https://github.com/apache/apisix-dashboard/blob/master/api/test/shell/cli_test.sh

done!

@jwrookie jwrookie requested a review from starsz March 9, 2022 09:55
@jwrookie
Copy link
Contributor Author

jwrookie commented Mar 9, 2022

have a check ,thx @starsz @nic-chen

@nic-chen nic-chen requested a review from bzp2010 March 10, 2022 00:38
@jwrookie
Copy link
Contributor Author

have a check, thx @bzp2010

@starsz starsz merged commit bc13bb9 into apache:master Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: caller in log is positioning error
5 participants