Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: caller in log is positioning error #2365

Closed
jwrookie opened this issue Mar 8, 2022 · 2 comments · Fixed by #2367
Closed

bug: caller in log is positioning error #2365

jwrookie opened this issue Mar 8, 2022 · 2 comments · Fixed by #2367
Assignees
Labels
bug Something isn't working

Comments

@jwrookie
Copy link
Contributor

jwrookie commented Mar 8, 2022

Issue description

caller in log is positioning error

1646709945670

Expected behavior

caller should is internal/filter/logging.go:45

logger.Desugar().Info(path,
//zap.String("path", path),
zap.Int("status", statusCode),
zap.String("host", host),
zap.String("query", query),
zap.String("requestId", requestId),
zap.Duration("latency", latency),
zap.String("remoteIP", remoteIP),
zap.String("method", method),
//zap.String("respBody", respBody),
zap.Strings("errs", errs),
)
}

How to Reproduce

  1. start apisix-dashboard
  2. send request
  3. view access.log

Screenshots

No response

Environment

  • apisix version (cmd: apisix version):
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run etcd --version):
  • apisix-dashboard version, if have:
  • Browser version, if have:

Additional context

I want to solve it

@jwrookie jwrookie added the bug Something isn't working label Mar 8, 2022
@starsz
Copy link
Contributor

starsz commented Mar 9, 2022

Good capture !

@zaunist
Copy link
Contributor

zaunist commented Mar 9, 2022

Nice job !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants