Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQLDB falls back on pymysql #442

Closed
wants to merge 2 commits into from
Closed

MySQLDB falls back on pymysql #442

wants to merge 2 commits into from

Conversation

mistercrunch
Copy link
Member

@LilithWittmann , I decided to privilege MySQLDB over pymysql since it's written in C and probably is more optimized and less disruptive overall to keep it as deps in extras_require don't get applied unless specified.

I still left pymysql in setup.py though for py3 compatibility, people can install MySQLDB if they prefer it for some reason.

Original PR: #424

@LilithWittmann
Copy link
Contributor

OK sounds like a good idea!

@mistercrunch
Copy link
Member Author

I'm having problems with SqlAlchemy when setting my connection URI to mysql+pymysql://, I'll have to dig deeper before I can merge this.

@mistercrunch
Copy link
Member Author

The master branch now uses mysqlclient, which is py3 compatible and a drop in replacement for mysql-python

@mrwillis
Copy link

Hi, sorry this is old but I can't see on master that this is changed: link.

Is there any plans to support mysqlclient or another python3 friendly driver?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants