Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace mysql-python with pymysql for python3 compatibility #424

Closed
wants to merge 1 commit into from
Closed

replace mysql-python with pymysql for python3 compatibility #424

wants to merge 1 commit into from

Conversation

LilithWittmann
Copy link
Contributor

@mistercrunch
Copy link
Member

This is a bit scary, I'll have to run exhaustive tests. I'm not convinced that setuptools with extras_require will do the right thing (installing pymysql) without a glitch.

Maybe the solution is to try: importing MySQLdb and fall back on pymysql, at least until we release Airflow 2.0.0. The setup.py can only reference pymysql, but at least we don't break existing installs.

I double checked that the fancy cursors are supported by pymysql. Luckily it looks like the author has kept the same interface.

@mistercrunch mistercrunch mentioned this pull request Sep 21, 2015
Closed
@mistercrunch
Copy link
Member

Moved this PR locally to #442, closing

@jlowin jlowin mentioned this pull request Mar 28, 2016
Closed
mobuchowski added a commit to mobuchowski/airflow that referenced this pull request Jan 4, 2022
@mobuchowski @pawel-big-lebowski @collado-mike
[INTEGRATION][Spark] Increase visitor coverage (apache#393)
fdc7890 
* spark: visitors for commands

Signed-off-by: Maciej Obuchowski <[email protected]>

* spark: emit on sql events (apache#404)

Signed-off-by: Maciej Obuchowski <[email protected]>

* OptimizedCreateHiveTableAsSelectCommandVisitor with tests (apache#414)

Signed-off-by: Pawel Leszczynski <[email protected]>

* AlterTableCommands visitors (apache#415)

Signed-off-by: Pawel Leszczynski <[email protected]>

* spark: implement PathUtils (apache#416)

Signed-off-by: Maciej Obuchowski <[email protected]>

* spark: move existing visitor implementations to PathUtils (apache#417)

Signed-off-by: Maciej Obuchowski <[email protected]>

* spark: split CreateTableLikeCommandVisitor implementation due to api change (apache#418)

Signed-off-by: Maciej Obuchowski <[email protected]>

* [INTEGRATION][Spark] implement DataFrameWriterV2's CreateTableAsSelect (apache#419)

* spark: split CreateTableLikeCommandVisitor implementation due to api change

Signed-off-by: Maciej Obuchowski <[email protected]>

* spark: implement DataFrameWriterV2's CreateTableAsSelect for Iceberg and Delta

Signed-off-by: Maciej Obuchowski <[email protected]>

* merge fromHiveTable & fromCatalogTable methods (apache#432)

Signed-off-by: Pawel Leszczynski <[email protected]>

* create & drop table with tests (apache#424)

Signed-off-by: Pawel Leszczynski <[email protected]>

Co-authored-by: pawel.leszczynski <[email protected]>
Co-authored-by: Michael Collado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LilithWittmann @mistercrunch