-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all deprecations cncf.kubernetes #43689
Merged
eladkal
merged 16 commits into
apache:main
from
romsharon98:feature/remove-deprecations-warnings-from-cncf-kubernetes
Nov 9, 2024
Merged
remove all deprecations cncf.kubernetes #43689
eladkal
merged 16 commits into
apache:main
from
romsharon98:feature/remove-deprecations-warnings-from-cncf-kubernetes
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
jedcunningham and
hussein-awala
as code owners
November 5, 2024 12:25
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
labels
Nov 5, 2024
eladkal
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
needs to update changelog to list the removals
romsharon98
changed the title
remove deprecations warnings from cncf kubernetes
remove all deprecations cncf.kubernetes
Nov 5, 2024
eladkal
reviewed
Nov 5, 2024
eladkal
reviewed
Nov 6, 2024
romsharon98
force-pushed
the
feature/remove-deprecations-warnings-from-cncf-kubernetes
branch
from
November 6, 2024 12:50
f66b09d
to
e0268c4
Compare
static checks are failing |
romsharon98
commented
Nov 7, 2024
eladkal
approved these changes
Nov 9, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* change default namespace value to be None * revert ui change * remove deprecations from cncf.kubernetes * add changelog * add list of changes in changelog * Update providers/src/airflow/providers/cncf/kubernetes/CHANGELOG.rst * fix tests * fix tests * update changelog, remove deprecation warnings from tests * add todo comment for removing import * remove kubernetes_pod as deprecated module * remove unecessary test, add import for deprecation * fix tests * fix tests and imports * fix tests * add ignore re-def in correct place --------- Co-authored-by: Elad Kalif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we now change the provider version to be 10.0.0 we can now remove all the deprecation warnings.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.