Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all deprecations cncf.kubernetes #43689

Conversation

romsharon98
Copy link
Contributor

since we now change the provider version to be 10.0.0 we can now remove all the deprecation warnings.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
needs to update changelog to list the removals

@romsharon98 romsharon98 changed the title remove deprecations warnings from cncf kubernetes remove all deprecations cncf.kubernetes Nov 5, 2024
@romsharon98 romsharon98 force-pushed the feature/remove-deprecations-warnings-from-cncf-kubernetes branch from f66b09d to e0268c4 Compare November 6, 2024 12:50
@eladkal
Copy link
Contributor

eladkal commented Nov 6, 2024

static checks are failing

@eladkal eladkal merged commit 6d85a04 into apache:main Nov 9, 2024
82 checks passed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* change default namespace value to be None

* revert ui change

* remove deprecations from cncf.kubernetes

* add changelog

* add list of changes in changelog

* Update providers/src/airflow/providers/cncf/kubernetes/CHANGELOG.rst

* fix tests

* fix tests

* update changelog, remove deprecation warnings from tests

* add todo comment for removing import

* remove kubernetes_pod as deprecated module

* remove unecessary test, add import for deprecation

* fix tests

* fix tests and imports

* fix tests

* add ignore re-def in correct place

---------

Co-authored-by: Elad Kalif <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants