Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple volume_configurations from capacity_provider_strategy #43047

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

pyrr
Copy link
Contributor

@pyrr pyrr commented Oct 15, 2024

closes: #43046


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Oct 15, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Nov 4, 2024

@pyrr can you rebase and resolve conflicts?
Also please add unit test to avoid regression

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

@eladkal done.

@romsharon98
Copy link
Contributor

@eladkal done.

Static checks need to be fixed

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

Static checks need to be fixed

@romsharon98 Fixed extra parameter issue-- should work now but I'm not sure how to run the unit tests on my end without waiting for you to trigger the workflow.

@romsharon98
Copy link
Contributor

Static checks need to be fixed

@romsharon98 Fixed extra parameter issue-- should work now but I'm not sure how to run the unit tests on my end without waiting for you to trigger the workflow.

You can read more about how to run tests locally here

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

Static checks need to be fixed

@romsharon98 Fixed extra parameter issue-- should work now but I'm not sure how to run the unit tests on my end without waiting for you to trigger the workflow.

You can read more about how to run tests locally here

Thanks, will fix new error and QA tests on my side this time before requesting review.

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

@romsharon98

Tested locally + squashed the bug fix commits into one, good to retry workflow.

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

@o-nikolas

Thanks for re-running the workflow, I see the tests are still failing. Not sure why since it works when I run the suite using breeze on my machine. Will investigate again.

@eladkal
Copy link
Contributor

eladkal commented Nov 5, 2024

@o-nikolas

Thanks for re-running the workflow, I see the tests are still failing. Not sure why since it works when I run the suite using breeze on my machine. Will investigate again.

It fails on static checks. You just need to install and enable pre commit. It will automaticly fix it

@pyrr
Copy link
Contributor Author

pyrr commented Nov 5, 2024

Thanks @eladkal , I applied the pre-commit changes and fixed an additional issue with the expected_args.

Also @potiuk @ashb apologies for the code review request-- I committed another file I had modified locally for local testing.

@eladkal eladkal merged commit 995cd8f into apache:main Nov 6, 2024
56 checks passed
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…`capacity_provider_strategy` (apache#43047)

* Decouple volume_configurations from capacity_provider_strategy

* Add tests for volume configurations

* Add EOF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary dependence between capacity_provider_strategy and volume_configurations
4 participants