-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple volume_configurations from capacity_provider_strategy #43047
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@pyrr can you rebase and resolve conflicts? |
@eladkal done. |
Static checks need to be fixed |
@romsharon98 Fixed extra parameter issue-- should work now but I'm not sure how to run the unit tests on my end without waiting for you to trigger the workflow. |
You can read more about how to run tests locally here |
Thanks, will fix new error and QA tests on my side this time before requesting review. |
Tested locally + squashed the bug fix commits into one, good to retry workflow. |
Thanks for re-running the workflow, I see the tests are still failing. Not sure why since it works when I run the suite using breeze on my machine. Will investigate again. |
It fails on static checks. You just need to install and enable pre commit. It will automaticly fix it |
…`capacity_provider_strategy` (apache#43047) * Decouple volume_configurations from capacity_provider_strategy * Add tests for volume configurations * Add EOF
closes: #43046
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.