-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets UI Improvements #40871
Datasets UI Improvements #40871
Conversation
@bbovenzi can we have a scroll in the list of cards showing dataset events extra? Also spacing between source and extras increases as we increase num of extra Screen.Recording.2024-07-22.at.4.31.08.PM.mov |
@bbovenzi is it possible to provide DAG run id link in source and triggered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inspected code - unfortunately I am not to deep into React code and in Datasets... but did a manual check, looks like working as expected.
Ok I have a follow up branch for a event details page. Perhaps we should only show |
1aea34e
to
4280c7a
Compare
I added links to datasets, dagruns and task instances. Also, we're now using the same card component in the DAG details. I switched the |
@bbovenzi looked good to me |
* Update Datasets page UX * Cleanup selected dataset event code * Use DatasetEventCard everywhere, use RenderedJson for extra, add links
In anticipation of Dataset Aliases, the Datasets page is getting a refresh. What really matters are events, so this update allows us to emphasize Dataset Events and sets us up to show more event details in the future.
Most notably,
DAG details also using the new dataset event cards:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.