Implement context accessor for DatasetEvent extra #38481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
reviewed
Mar 26, 2024
uranusjr
force-pushed
the
dataset-event-extra-context
branch
from
54834d2
to
8380a93
Compare
Lee-W
approved these changes
Mar 26, 2024
uranusjr
force-pushed
the
dataset-event-extra-context
branch
from
8380a93
to
712e37b
Compare
jscheffl
reviewed
Mar 27, 2024
There was a problem hiding this comment.
I like the approach as proposed here. Besides the comments to the review, can I kindly request that the existing dataset example is extended such that the "new function" is used there as a good example? Benefit would also be that there is an example existing how to retrieve the extra when receiving the event. At the moment it is a bit complex for somebody trying to figure this out.
uranusjr
force-pushed
the
dataset-event-extra-context
branch
from
e8abd59
to
47da435
Compare
jscheffl
reviewed
Mar 28, 2024
uranusjr
force-pushed
the
dataset-event-extra-context
branch
from
47da435
to
2996db3
Compare
potiuk
approved these changes
Mar 28, 2024
2 tasks
|
Covered in: #40871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #37810 for details. This implements the
dataset_eventscontext key to addextrato a given dataset event that’s to be emitted by the task.I can use some help with how to do the UI part.