Add smtp provider to prod_image_installed_providers.txt #37739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@potiuk I'm not sure who the code owner for this file is.. could you take a look? |
|
You need to rebase your PR. |
|
Actually ... you were perfectly correct. It was missing there 🤦 |
potiuk
approved these changes
Feb 27, 2024
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 2b67a75)
14 tasks
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into the prod image tests failing in #37733
FAILED docker_tests/test_prod_image.py::TestPythonPackages::test_required_providers_are_installed
E AssertionError: List of expected installed packages and image content mismatch. Check /home/runner/work/airflow/airflow/prod_image_installed_providers.txt file.
....
E Extra items in the right set:
E 'apache-airflow-providers-smtp'
Based on #37701 it seems that the smtp provider is now preinstalled on the prod image.
Tested locally with breeze prod-image build and breeze prod-image verify