Fix backwards compatibility for SMTP provider #37701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @vchiapaikeo . FYI. I guess you moved the import as local imports to solve "compatibility checks" failing in CI - but as a learning for the future - DON't :) . The compatibility checks deliberately fail when there are imports that are importing stuff from airlfow - and we perform import checks for all the providers to see if the imports still work, local imports are a way to avoid that, but also they will stop detecting compatibility issues. Also note to self (and others) to pay closer attention to such changes :D |
potiuk
changed the title
The apache#36226 introduced backwards compatibility check for the smtp provider, where it relied pn airflow settings containig new settings. This PR fixes it by falling back to default settings in case the settings cannot be imported.
potiuk
force-pushed
the
fix-backwards-compatibility-check-for-smtp-provider
branch
from
e134ed0 to
b318f0e
Compare
eladkal
approved these changes
Feb 26, 2024
Taragolis
reviewed
Feb 26, 2024
potiuk
deleted the
fix-backwards-compatibility-check-for-smtp-provider
branch
3 tasks
|
Oof, I'm sorry guys! I'll try to fix this right up! |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 26, 2024
Related apache#36226 and apache#37701 - where we had problems with SMTP provider 1.6.0.
potiuk
added a commit
that referenced
this pull request
Feb 26, 2024
79 tasks
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 6, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #36226 introduced backwards compatibility check for the smtp provider, where it relied pn airflow settings containig new settings.
This PR fixes it by falling back to default settings in case the settings cannot be imported.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.