Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiselect to run state in grid view #35403

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Add multiselect to run state in grid view #35403

merged 8 commits into from
Dec 1, 2023

Conversation

vchiapaikeo
Copy link
Contributor

@vchiapaikeo vchiapaikeo commented Nov 3, 2023 •
edited
Loading

closes: #34795

multi-select-grid-view.mov
test-search-params.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Nov 3, 2023
@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch 2 times, most recently from 0897dd3 to b7f5db6 Compare November 6, 2023 18:25
@bbovenzi
Copy link
Contributor

Nice. I wonder if listing all of the options by default is the best UX, vs leaving it empty and showing all states.

@vchiapaikeo
Copy link
Contributor Author

Yes, good point. I could even sub it for something like "All Run States". Will get a demo out showing that as well.

Also, what do you think about doing the same for run types? And are you okay with the way it is serialized as a csv with the bulk of the manipulation logic on the JSX side?

@bbovenzi
Copy link
Contributor

Yes, good point. I could even sub it for something like "All Run States". Will get a demo out showing that as well.

Also, what do you think about doing the same for run types? And are you okay with the way it is serialized as a csv with the bulk of the manipulation logic on the JSX side?

"All run states" sounds great. Let's do both run state and run type. I think the logic in the PR now looks good.

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b7f5db6 to b939ef4 Compare November 18, 2023 02:19
@vchiapaikeo
Copy link
Contributor Author

vchiapaikeo commented Nov 18, 2023 •
edited
Loading

Great. Still need to do some work on tests.

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b939ef4 to 7ef33e0 Compare November 18, 2023 13:22
@vchiapaikeo
Copy link
Contributor Author

Latest demo:

multiselect-demo2.mov

@potiuk
Copy link
Member

potiuk commented Nov 18, 2023

Nice!

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from b77aa83 to b98dfca Compare November 19, 2023 16:12
eladkal
eladkal approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@eladkal eladkal added this to the Airflow 2.8.0 milestone Nov 24, 2023
@eladkal eladkal added the type:improvement Changelog: Improvements label Nov 24, 2023
@eladkal
Copy link
Contributor

eladkal commented Nov 24, 2023

cc @bbovenzi can we merge?

bbovenzi
bbovenzi approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS code looks good

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from 0fa54a4 to 2a4d949 Compare November 29, 2023 15:08
@vchiapaikeo
Copy link
Contributor Author

Latest demo:

multiselect.mov

@vchiapaikeo
Copy link
Contributor Author

I think we are good to merge here.

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/k8s-cncf-check-v3 branch from 2a4d949 to 777580f Compare December 1, 2023 14:48
@pierrejeambrun
Copy link
Member

Nice, thank you!

@pierrejeambrun pierrejeambrun merged commit 9e28475 into apache:main Dec 1, 2023
47 checks passed
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
@vchiapaikeo @ephraimbuddy
Add multiselect to run state in grid view (#35403)
4652d7f 
* Add multiselect to run state in grid view

* Fix tests

* Multiselect for run types, UI nits, refactor

* Fix tests, refactor

* Simplify multiselect value

* Nits and refactor

* Use arrays instead of serializing to csv

* Fix tests and global axios paramsSerializer to null

(cherry picked from commit 9e28475)
@potiuk potiuk mentioned this pull request Dec 11, 2023
Merged
@sean-rose sean-rose mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi bbovenzi approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@potiuk potiuk Awaiting requested review from potiuk

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Milestone
Airflow 2.8.0
Development

Successfully merging this pull request may close these issues.

Support multi-select state filtering on grid view
5 participants
@vchiapaikeo @bbovenzi @potiuk @eladkal @pierrejeambrun