Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-select state filtering on grid view #34795

Closed
2 tasks done
Usiel opened this issue Oct 6, 2023 · 5 comments · Fixed by #35403
Closed
2 tasks done

Support multi-select state filtering on grid view #34795

Usiel opened this issue Oct 6, 2023 · 5 comments · Fixed by #35403
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@Usiel
Copy link
Contributor

Usiel commented Oct 6, 2023

Description

Replace the existing selects with multi-selects that allow you to filter multiple DAG run states and types at the same time, somewhat similar to my prototype:

image

Use case/motivation

I'm not sure if it is just me, but sometimes I wish I was able to show multiple DAG run states, especially running and failed, at the same time.
This would be especially helpful for busy DAGs on which I want to clear a few failed runs. Without the multi-select, if I switch from failed to running DAG runs, I need to orient myself again to find the run I just cleared (assuming there are lots of other running DAG runs). With the multi-select, the DAG run I just cleared stays in the same spot and I can check the logs, while clearing some other failed runs.

I'm not sure we need a multi-select for DAG run types as well. I'd tend to say no, but maybe someone else has a use-case for that.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Usiel Usiel added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Oct 6, 2023
@Adaverse
Copy link
Contributor

Yup, it would be nice to have.

@RNHTTR RNHTTR added area:UI Related to UI/UX. For Frontend Developers. and removed needs-triage label for new issues that we didn't triage yet labels Oct 18, 2023
@vchiapaikeo
Copy link
Contributor

Happy to give this a try!

@potiuk
Copy link
Member

potiuk commented Nov 2, 2023

Pls

@Usiel
Copy link
Contributor Author

Usiel commented Nov 3, 2023

Happy to give this a try!

Sure, go ahead! I already previously started a prototype, maybe it helps: main...Usiel:airflow:usiel/add-multi-dag-state-filter

@vchiapaikeo
Copy link
Contributor

Nice! I used a similar approach but kept the array serialized as a csv so that we wouldn't have to change all the method signatures in useFilters. Your styling was very helpful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants