Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add S3Bucket for mypy #33028

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add S3Bucket for mypy #33028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/providers/amazon/aws/hooks/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
from airflow.utils.helpers import chunks

if TYPE_CHECKING:
from mypy_boto3_s3.service_resource import Object as S3ResourceObject
from mypy_boto3_s3.service_resource import Bucket as S3Bucket, Object as S3ResourceObject

T = TypeVar("T", bound=Callable)

Expand Down Expand Up @@ -298,7 +298,7 @@ def check_for_bucket(self, bucket_name: str | None = None) -> bool:
return False

@provide_bucket_name
def get_bucket(self, bucket_name: str | None = None) -> object:
def get_bucket(self, bucket_name: str | None = None) -> S3Bucket:
"""
Returns a :py:class:`S3.Bucket` object.

Expand Down