-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3Bucket for mypy #33028
Add S3Bucket for mypy #33028
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Please run static checks, they are currently failing. You can either use Breeze or |
c192898
to
41b2c96
Compare
@vincbeck Thanks. I applied |
Nice! Thanks for doing the change! |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Fixing Simple mypy typing for S3Bucket.
For example, this code cannot pass mypy typing because of get_bucket return simple 'object'
airflow/airflow/providers/amazon/aws/hooks/s3.py
Line 301 in df74553
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.