Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executor_class from Job - fixing backfil for custom executors #32219

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Remove executor_class from Job - fixing backfil for custom executors #32219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions airflow/jobs/backfill_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,10 +540,7 @@ def _per_task_process(key, ti: TaskInstance, session):

cfg_path = None

executor_class, _ = ExecutorLoader.import_executor_cls(
self.job.executor_class,
)
if executor_class.is_local:
if executor.is_local:
cfg_path = tmp_configuration_copy()

executor.queue_task_instance(
Expand Down
3 changes: 0 additions & 3 deletions airflow/jobs/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,6 @@ def __init__(self, executor=None, heartrate=None, **kwargs):
self.hostname = get_hostname()
if executor:
self.executor = executor
self.executor_class = executor.__class__.__name__
else:
self.executor_class = conf.get("core", "EXECUTOR")
self.start_date = timezone.utcnow()
self.latest_heartbeat = timezone.utcnow()
if heartrate is not None:
Expand Down
1 change: 0 additions & 1 deletion tests/jobs/test_base_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,6 @@ def test_essential_attr(self, mock_getuser, mock_hostname, mock_default_executor

test_job = Job(heartrate=10, dag_id="example_dag", state=State.RUNNING)
MockJobRunner(job=test_job)
assert test_job.executor_class == "SequentialExecutor"
assert test_job.heartrate == 10
assert test_job.dag_id == "example_dag"
assert test_job.hostname == "test_hostname"
Expand Down