Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executor_class from Job - fixing backfil for custom executors #32219

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 27, 2023

The executor_class in job was used in the past to pass information about executor being used but it has been replaced by executor passed via JobRunner when needed. The executor_class has only been used in backfill job, but it has been used wrongly - because it had no fully qualified path there.

The right way of using it is to check the executor passed via JobRunner, and since executor_class is not used any more, we can safely remove it

This fixes a bug when custom executors could not be used
during backfill.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested review from kaxil, ashb and XD-DENG as code owners June 27, 2023 22:18
@boring-cyborg boring-cyborg bot added the area:Scheduler including HA (high availability) scheduler label Jun 27, 2023
The executor_class in job was used in the past to pass information
about executor being used but it has been replaced by executor
passed via JobRunner when needed. The executor_class has only
been used in backfill job, but it has been used wrongly - because
it had no fully qualified path there.

The right way of using it is to check the executor passed via
JobRunner, and since executor_class is not used any more, we
can safely remove it.

This fixes a bug when custom exceutors could not be used
during backfill.

Co-Authored-By: Andrew Halpern <[email protected]>
@potiuk potiuk force-pushed the fix-executor-class-check-for-backfill branch from 99ebdc9 to 7783a3f Compare June 27, 2023 22:29
@potiuk potiuk changed the title Remove executor_class from Job Remove executor_class from Job - fixing backfil for custom executors Jun 27, 2023
@potiuk
Copy link
Member Author

potiuk commented Jun 27, 2023

More complete version of #32101 proposed by @adh-wonolo (thanks for the fix propal and being co-author of this change :) )

@potiuk potiuk added this to the Airlfow 2.6.3 milestone Jun 27, 2023
@potiuk potiuk merged commit df4026a into apache:main Jun 28, 2023
@potiuk potiuk deleted the fix-executor-class-check-for-backfill branch June 28, 2023 05:32
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jul 6, 2023
ephraimbuddy pushed a commit that referenced this pull request Jul 6, 2023
…32219)

The executor_class in job was used in the past to pass information
about executor being used but it has been replaced by executor
passed via JobRunner when needed. The executor_class has only
been used in backfill job, but it has been used wrongly - because
it had no fully qualified path there.

The right way of using it is to check the executor passed via
JobRunner, and since executor_class is not used any more, we
can safely remove it.

This fixes a bug when custom exceutors could not be used
during backfill.

Co-authored-by: Andrew Halpern <[email protected]>
(cherry picked from commit df4026a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler including HA (high availability) scheduler type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants