Fix Breeze failing with error on Windows #30464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError. Related: apache#30405 (comment) Fixes: apache#30465
potiuk
force-pushed
the
fix-windows-timeout-for-breeze
branch
from
eb9f451 to
e5edc6c
Compare
|
Whoa. We have our first Windows user of Breeze it seems. cc: @Bowrna @edithturn |
eladkal
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When breeze is run on Windows it fails with FileNotFoundException when running uname during emulation check. This is now fixed alongside fixing TimeoutError misplacement - after moving it to local import, an exception triggered before importing it causes UnboundLocaalError.
Related: #30405 (comment)
Fixes: #30465
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.