Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create audit_logs.rst #30405

Merged
merged 16 commits into from
Apr 14, 2023
Merged

Create audit_logs.rst #30405

merged 16 commits into from
Apr 14, 2023

Conversation

rohan472000
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 31, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@rohan472000
Copy link
Contributor Author

rohan472000 commented Apr 1, 2023

@potiuk , please add review for any change needed.

Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small formatting suggestion -- similar to a previous one -- but LGTM.

@josh-fell
Copy link
Contributor

@rohan472000 Can you address the CI failures when you get a chance please?

You should be able to run both static checks and the build docs processes locally with Breeze.

@rohan472000
Copy link
Contributor Author

@rohan472000 Can you address the CI failures when you get a chance please?

You should be able to run both static checks and the build docs processes locally with Breeze.

@josh-fell pipx is installed but showing pipx command not found, means it is not on PATH, how to set its path, after following BREEZE.rst also I'm getting problem

@rohan472000
Copy link
Contributor Author

while installing BREEZE , I'm getting below error

PS C:\pycharm\codes\airflow-repo-clone> pipx install -e ./dev/breeze
Unable to parse package spec: ./dev/breeze

@potiuk
Copy link
Member

potiuk commented Apr 4, 2023

while installing BREEZE , I'm getting below error

PS C:\pycharm\codes\airflow-repo-clone> pipx install -e ./dev/breeze Unable to parse package spec: ./dev/breeze

You are on Windows. You should use backslashes and you shoudl use windows path specification which I guess is .\dev\breeze.

@potiuk
Copy link
Member

potiuk commented Apr 4, 2023

BTW @rohan472000 once you figure out the right way of using it, I would highly appreciate PR to our docs describing it to users like you who might not realize that ./dev/breeze is path to the folder. I think you are the best person to explain it in the words that users like you would understand.

@rohan472000
Copy link
Contributor Author

BTW @rohan472000 once you figure out the right way of using it, I would highly appreciate PR to our docs describing it to users like you who might not realize that ./dev/breeze is path to the folder. I think you are the best person to explain it in the words that users like you would understand.

wow.. I was thinking of same @potiuk , I figured out the way and doing checks, after this I will do that docs also.

@rohan472000
Copy link
Contributor Author

after running pre-commit run , it asked me to run breeze setup regenerate-command-images but while running it I got below errors

PS C:\pycharm\codes\airflow-repo-clone\airflow> breeze setup regenerate-command-images
Traceback (most recent call last):
File "C:\pycharm\codes\airflow-repo-clone\airflow\dev\breeze\src\airflow_breeze\commands\main_command.py", line 122, in check_for_python_emulation
system_machine = subprocess.check_output(["uname", "-m"], text=True).strip()
File "C:\python3.10\setup\lib\subprocess.py", line 420, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "C:\python3.10\setup\lib\subprocess.py", line 501, in run
with Popen(*popenargs, **kwargs) as process:
File "C:\python3.10\setup\lib\subprocess.py", line 966, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "C:\python3.10\setup\lib\subprocess.py", line 1435, in _execute_child
hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "C:\python3.10\setup\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\python3.10\setup\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "c:\users\anand.local\bin\breeze.exe_main
.py", line 7, in
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\core.py", line 1130, in call
return self.main(*args, **kwargs)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\rich_click\rich_group.py", line 21, in main
rv = super().main(*args, standalone_mode=False, **kwargs)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\core.py", line 1055, in main
rv = self.invoke(ctx)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\core.py", line 1654, in invoke
super().invoke(ctx)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "C:\Users\anand.local\pipx\venvs\apache-airflow-breeze\lib\site-packages\click\decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "C:\pycharm\codes\airflow-repo-clone\airflow\dev\breeze\src\airflow_breeze\commands\main_command.py", line 114, in main
check_for_python_emulation()
File "C:\pycharm\codes\airflow-repo-clone\airflow\dev\breeze\src\airflow_breeze\commands\main_command.py", line 146, in check_for_python_emulation
except TimeoutOccurred:
UnboundLocalError: local variable 'TimeoutOccurred' referenced before assignment

@potiuk
Copy link
Member

potiuk commented Apr 4, 2023

Can you please report it as an issue - @rohan472000 (and any others you might encounter). Seems you are one of the 0.00N% of people who attempt to use breeze on windows, so I would like to use this as an opportunity to fix such compatibility issues.

In the meantime if you want to run this command please install WSEL2 and checkout your branch there - you will be able to run the command without any problems.

potiuk added a commit to potiuk/airflow that referenced this pull request Apr 4, 2023
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: apache#30405 (comment)

Fixes: apache#30465
potiuk added a commit that referenced this pull request Apr 4, 2023
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: #30405 (comment)

Fixes: #30465
@rohan472000
Copy link
Contributor Author

rohan472000 commented Apr 6, 2023

@potiuk kindly approve workflow to run.

@rohan472000
Copy link
Contributor Author

@potiuk kindly review it.

@potiuk potiuk added this to the Airflow 2.6.0 milestone Apr 14, 2023
@potiuk potiuk merged commit 9590398 into apache:main Apr 14, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 14, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added the type:doc-only Changelog: Doc Only label Apr 14, 2023
ephraimbuddy pushed a commit that referenced this pull request Apr 14, 2023
---------

Co-authored-by: Josh Fell <[email protected]>
(cherry picked from commit 9590398)
wookiist pushed a commit to wookiist/airflow that referenced this pull request Apr 19, 2023

---------

Co-authored-by: Josh Fell <[email protected]>
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 12, 2023
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: apache/airflow#30405 (comment)

Fixes: #30465
GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2023
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: apache/airflow#30405 (comment)

Fixes: #30465
GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 19, 2024
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: apache/airflow#30405 (comment)

Fixes: #30465
GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 8, 2024
When breeze is run on Windows it fails with FileNotFoundException
when running uname during emulation check. This is now fixed alongside
fixing TimeoutError misplacement - after moving it to local import,
an exception triggered before importing it causes UnboundLocaalError.

Related: apache/airflow#30405 (comment)

Fixes: #30465
GitOrigin-RevId: 56ff116ab3a005a07d62adbb7a0bdc0443cf2b85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants