Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid task log, multi select and ts files migration. #24623

Merged

Conversation

pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jun 23, 2022

Followup on #24403.

  • Adding support for multi select on the log level (via chakra-react-select)
  • Migrating some files to ts

@bbovenzi , we discussed about removing colors in the drop down. Adding colors inside the logs is not trivial. Even without colors in the logs, I think the left border in the drop down makes it easier to identify the level we are looking for.

I will happily change the style depending on your feedback.

Edit: Converting to draft, not ready. I would like to also migrate associated test file to ts in this PR.

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 23, 2022
@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch 4 times, most recently from 6873cb1 to 69eb029 Compare June 23, 2022 23:21
@pierrejeambrun pierrejeambrun marked this pull request as draft June 24, 2022 07:19
@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch 2 times, most recently from 71ca55f to c442e61 Compare June 27, 2022 20:48
@pierrejeambrun pierrejeambrun marked this pull request as ready for review June 27, 2022 20:49
@bbovenzi
Copy link
Contributor

Screen Shot 2022-06-27 at 5 14 32 PM

The font colors aren't matching.

Don't we want the multi-select for the file source too?

@pierrejeambrun
Copy link
Member Author

pierrejeambrun commented Jun 27, 2022

Screen Shot 2022-06-27 at 5 14 32 PM

The font colors aren't matching.

Don't we want the multi-select for the file source too?

Yes I was wondering that too, I can add the multi select there.

@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch from 1b92c31 to 9ac16b3 Compare June 27, 2022 23:07
@bbovenzi
Copy link
Contributor

Let's update the scrollIntoView() effect to be based off of the parsedLogs and not data. The scroll position is lost when filtering.

@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch 2 times, most recently from fb39ca9 to 5412239 Compare June 28, 2022 18:40
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! this keeps becoming a more useful view

@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch from 5412239 to 3f715e5 Compare June 28, 2022 19:12
@potiuk potiuk force-pushed the grid-view-logs-multi-select-on-level branch from 3f715e5 to 0e2b099 Compare June 28, 2022 21:35
@pierrejeambrun pierrejeambrun force-pushed the grid-view-logs-multi-select-on-level branch from 0e2b099 to d5a984c Compare June 28, 2022 21:51
@bbovenzi bbovenzi merged commit 75db755 into apache:main Jun 28, 2022
@pierrejeambrun pierrejeambrun deleted the grid-view-logs-multi-select-on-level branch June 29, 2022 17:12
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants