-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid task log, multi select and ts files migration. #24623
Merged
bbovenzi
merged 5 commits into
apache:main
from
pierrejeambrun:grid-view-logs-multi-select-on-level
Jun 28, 2022
Merged
Grid task log, multi select and ts files migration. #24623
bbovenzi
merged 5 commits into
apache:main
from
pierrejeambrun:grid-view-logs-multi-select-on-level
Jun 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
June 23, 2022 23:03
boring-cyborg
bot
added
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
labels
Jun 23, 2022
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
4 times, most recently
from
June 23, 2022 23:21
6873cb1
to
69eb029
Compare
bbovenzi
reviewed
Jun 24, 2022
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
2 times, most recently
from
June 27, 2022 20:48
71ca55f
to
c442e61
Compare
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
June 27, 2022 23:07
1b92c31
to
9ac16b3
Compare
Let's update the |
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
2 times, most recently
from
June 28, 2022 18:40
fb39ca9
to
5412239
Compare
bbovenzi
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! this keeps becoming a more useful view
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
June 28, 2022 19:12
5412239
to
3f715e5
Compare
potiuk
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
June 28, 2022 21:35
3f715e5
to
0e2b099
Compare
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
June 28, 2022 21:51
0e2b099
to
d5a984c
Compare
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:UI
Related to UI/UX. For Frontend Developers.
area:webserver
Webserver related Issues
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #24403.
@bbovenzi , we discussed about removing colors in the drop down. Adding colors inside the logs is not trivial. Even without colors in the logs, I think the left border in the drop down makes it easier to identify the level we are looking for.
I will happily change the style depending on your feedback.
Edit: Converting to draft, not ready. I would like to also migrate associated test file to ts in this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst
, in newsfragments.