-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid task logs filtering and local time #24403
Grid task logs filtering and local time #24403
Conversation
8e9b510
to
2a1b43a
Compare
airflow/www/static/js/grid/details/content/taskInstance/Logs/utils.js
Outdated
Show resolved
Hide resolved
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
ee02318
to
c409056
Compare
airflow/www/static/js/grid/details/content/taskInstance/Logs/utils.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I think people will be really excited for all of this!
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
e9f3a2e
to
2c4e83d
Compare
2c4e83d
to
4f04586
Compare
Follow up of #24249.
Enforcing log parsing to add:
The parsing function is quite light at the moment, I still decided to memoized the results as I assume this could become quite expensive if the user requests the log
full_content
.I also moved moment initialization for tests from testUtils to jest-setup.js. (Sometimes tests don't need a wrapper, and we still have to import testUtils module to get moment defined)
Tested with mapped tasks and task group. ✔️
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst
, in newsfragments.