Fix timezone display for logs on UI #23075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksYermak
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
boring-cyborg
bot
added
area:UI
bbovenzi
approved these changes
Apr 21, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Cherry-pick of apache/airflow#23075 Fix timezone display for logs on UI Internal bug RELNOTES=BUGFIX Change-Id: Id1a20a676eb7dcebe3617f7a63120f3fc71b2131 GitOrigin-RevId: 548b75ea219cd879a0c52101b5c189ae1a84523c
2 tasks
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 6, 2022
Cherry-pick of apache/airflow#23075 Fix timezone display for logs on UI Internal bug RELNOTES=BUGFIX Change-Id: I1e7d48bb0f5e2b0d12e86dd90f59453c9a7766f4 GitOrigin-RevId: c97c1c6503b71f5cd2401e84b113f77f266e6dd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have fixed the bug with logs display in UI. The problem is that our time conversion doesn't work correctly. I will try to describe it below. On server side we create a logs in UTC time. After that on UI JavaScript takes this logs and for each timestamps changes UTC flag to flag which is indicated like serverTimezone. But without time conversion, for example for PDT timezone: 2022-04-13 12:15:00,117+00:00 time in log file, on UI will be changed to 2022-04-13 12:15:00,117−07:00 time. Then another JS code using a correct convert function converts this timestamp to a time with a serverTimezone and in result we will see 2022-04-13, 12:15:00 PDT. How you see now we have UTC time with PDT label and each next conversion will create an incorrect time view.
Co-authored-by: Wojciech Januszek [email protected]
Co-authored-by: Lukasz Wyszomirski [email protected]
Co-authored-by: Maksim Yermakou [email protected]
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.