-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log timezone in task log view (#19342) #19401
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calfzou Looking good, but please add a description to the PR.
@bbovenzi description added 😄 |
We aren't importing |
1473ae3
to
b31bb40
Compare
fixed ~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Awesome work, congrats on your first merged pull request! |
This bug occurs in 2.3.0 again https://github.com/apache/airflow/blob/2.3.0/airflow/www/static/js/ti_log.js |
might caused by recent change: #23075 |
Can you please open a new issue for that ? Thanks in advance |
ok, wait a moment |
Fix #19342 such that when using non-UTC timezone (change
default_timezone
and airflow server's timezone), task's log in web interface will give incorrect log times.Since python logging module saves
asctime
without timezone, the solution is simply add server's timezone offset (e.g. "Europe/Moscow" => "+03:00") to everyasctime
in the log file.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.