Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass custom headers through in SES email backend #22667

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Pass custom headers through in SES email backend #22667

merged 4 commits into from
Apr 6, 2022

Conversation

repl-mike-roest
Copy link
Contributor

@repl-mike-roest repl-mike-roest commented Mar 31, 2022 •
edited
Loading

I noticed while looking through the source that the SES email provider was not passing through the custom headers. This was fixed for SMTP in #19009 but SES appears to have been missed.
^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Mar 31, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 31, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@repl-mike-roest repl-mike-roest changed the title Pass custom headers through Pass custom headers through in SES email backend Mar 31, 2022
@repl-mike-roest repl-mike-roest force-pushed the pass-custom-headers-through branch from eba8af1 to eb60e86 Compare April 5, 2022 12:22
uranusjr
uranusjr reviewed Apr 6, 2022
View reviewed changes
airflow/providers/amazon/aws/utils/emailer.py
@@ -32,6 +32,7 @@ def send_email(
mime_charset: str = 'utf-8',
conn_id: str = 'aws_default',
from_email: Optional[str] = None,
custom_headers: Optional[Dict[str, Any]] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the value be Any? Email headers should be in str, aren’t they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the same typings that were used in #19009 for consistency. And it matches the signature of build_mime_message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s make this a separate discussion then.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit de84eaf into apache:main Apr 6, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 6, 2022

Awesome work, congrats on your first merged pull request!

@repl-mike-roest repl-mike-roest deleted the pass-custom-headers-through branch April 6, 2022 20:44
@potiuk potiuk mentioned this pull request Apr 7, 2022
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@repl-mike-roest @potiuk @uranusjr