Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass custom_headers to send_email and send_email_smtp #19009

Merged

Conversation

piorkowskiprzemyslaw
Copy link
Contributor

closes: #16740

@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Oct 15, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 15, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@piorkowskiprzemyslaw piorkowskiprzemyslaw marked this pull request as ready for review October 15, 2021 14:23
@piorkowskiprzemyslaw piorkowskiprzemyslaw marked this pull request as draft October 15, 2021 14:52
@piorkowskiprzemyslaw piorkowskiprzemyslaw marked this pull request as ready for review October 15, 2021 19:19
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 18, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal
Copy link
Contributor

eladkal commented Oct 21, 2021

@piorkowskiprzemyslaw
Copy link
Contributor Author

Should we also add a test to https://github.com/apache/airflow/blob/main/tests/operators/test_email.py ?

I have added assertion for custom_headers in this test.

@eladkal eladkal added this to the Airflow 2.2.3 milestone Nov 9, 2021
@uranusjr uranusjr merged commit c95205e into apache:main Nov 11, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 11, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom headers not passible to send_email
5 participants