Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update smart sensor docs and minor fix on is_smart_sensor_compatible() #22386

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

okayhooni
Copy link
Contributor

Even though smart sensor feature was deprecated and planned to be removed on version 2.4, the fact that sensor tasks with any callback arguments are not compatible with smart sensor, has to be noticed on the official docs.

@okayhooni okayhooni requested review from kaxil and potiuk as code owners March 20, 2022 18:09
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow kind:documentation labels Mar 20, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 21, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@okayhooni okayhooni force-pushed the minor/smart_sensor branch from 855972e to 51d6d4f Compare March 21, 2022 06:36
@potiuk potiuk force-pushed the minor/smart_sensor branch from db7c4cf to c99993e Compare March 21, 2022 19:21
@potiuk
Copy link
Member

potiuk commented Mar 24, 2022

Random failure. Merging.

@potiuk potiuk merged commit e164932 into apache:main Mar 24, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 24, 2022

Awesome work, congrats on your first merged pull request!

@eladkal eladkal added this to the Airflow 2.2.6 milestone Mar 24, 2022
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Apr 8, 2022
@eladkal eladkal modified the milestones: Airflow 2.2.6, Airflow 2.3.0 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge kind:documentation type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants