update smart sensor docs and minor fix on is_smart_sensor_compatible() (

#22386)
apache · Mar 24, 2022 · e164932 · e164932
1 parent 4e24b22
commit e164932
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/airflow/sensors/base.py b/airflow/sensors/base.py
@@ -181,9 +181,8 @@ def is_smart_sensor_compatible(self):
             self.on_retry_callback,
             self.on_failure_callback,
         ]
-        for status in check_list:
-            if status:
-                return False
+        if any(check_list):
+            return False
 
         operator = self.__class__.__name__
         return operator in self.sensors_support_sensor_service

diff --git a/docs/apache-airflow/concepts/smart-sensors.rst b/docs/apache-airflow/concepts/smart-sensors.rst
@@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need to be change
 enabling/disabling the smart sensor. Rotating centralized smart sensor tasks will not
 cause any user’s sensor task failure.
 
+*   Using callback arguments (``on_success_callback``, ``on_failure_callback``, and ``on_retry_callback``) on a sensor task is not compatible with the smart sensor mode. If any callback arguments are provided, the sensor task will not be executed when the smart sensor mode is enabled.
+
 Support new operators in the smart sensor service
 -------------------------------------------------