Correctly specify overloads for TaskFlow API for type-hinting #20933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The position of `@overload` matters -- at least to MyPy, and all function overloads have to be next to each other. I also removed the overload for `@task.docker`, as that one _requires_ at least an image to be passed, so isn't valid with no parameters
kaxil
approved these changes
Jan 18, 2022
|
Lets double check this does fix the mypy -- it did on my testing on one direct file, but sadly I don't trust it to behave the same when run with all files. |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
commented
Jan 18, 2022
|
Confirmed mypy changes good. |
|
Kube failure is an random EOF in the test harness, not a real problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position of
@overloadmatters -- at least to MyPy, and allfunction overloads have to be next to each other.
I also removed the overload for
@task.docker, as that one requiresat least an image to be passed, so isn't valid with no parameters
Closes #20929
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.