Remove all "fake" stub files #20936
Merged
Remove all "fake" stub files #20936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:Apache
provider:amazon
potiuk
requested review from
ashb,
dstandish,
ephraimbuddy,
jedcunningham,
kaxil and
uranusjr
potiuk
force-pushed
the
remove-fake-stub-files-for-mypy
branch
from
d7eba03 to
6f2bc16
Compare
ashb
reviewed
Jan 18, 2022
airflow/providers/microsoft/azure/example_dags/example_sftp_to_wasb.py
Outdated
Show resolved
Hide resolved
In order to improve MyPy check for example files we added fake stub files, it was supposed to be temporary solution and so it is. Adding fake stubs creates more problems than it solves. Instead - we ignore [call-arg] type of MyPy error for the example files affected (those that are using default_args). Part of apache#19891
potiuk
force-pushed
the
remove-fake-stub-files-for-mypy
branch
from
6f2bc16 to
12980d4
Compare
ashb
approved these changes
Jan 18, 2022
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve MyPy check for example files we added fake
stub files, it was supposed to be temporary solution and so it
is. Adding fake stubs creates more problems than it solves.
Instead - we ignore [call-arg] type of MyPy error for the example
files affected (those that are using default_args).
Part of #19891
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.