Upload KinD logs on cancell too #19554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the job times out, it is "cancelled", rather than failed, which means that the logs were not uploaded. This will likely also catch a few cases where the job is cancelled cos of another push to the branch/PR, but it's better to have too many logs than not enough to debug problems
kaxil
approved these changes
Nov 12, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
uranusjr
approved these changes
Nov 12, 2021
potiuk
pushed a commit
that referenced
this pull request
Jan 22, 2022
If the job times out, it is "cancelled", rather than failed, which means that the logs were not uploaded. This will likely also catch a few cases where the job is cancelled cos of another push to the branch/PR, but it's better to have too many logs than not enough to debug problems (cherry picked from commit 4f1e66d)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the job times out, it is "cancelled", rather than failed, which means
that the logs were not uploaded.
This will likely also catch a few cases where the job is cancelled cos
of another push to the branch/PR, but it's better to have too many logs
than not enough to debug problems
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.