Skip to content

Commit

Permalink
Upload KinD logs on cancell too (#19554)
Browse files Browse the repository at this point in the history
If the job times out, it is "cancelled", rather than failed, which means
that the logs were not uploaded.

This will likely also catch a few cases where the job is cancelled cos
of another push to the branch/PR, but it's better to have too many logs
than not enough to debug problems
  • Loading branch information
ashb authored Nov 12, 2021
1 parent a24066b commit 4f1e66d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
PR_LABELS: "${{ needs.build-info.outputs.pullRequestLabels }}"
- name: "Upload KinD logs"
uses: actions/upload-artifact@v2
if: failure()
if: failure() || cancelled()
with:
name: >
kind-logs-${{matrix.executor}}
Expand Down Expand Up @@ -1124,7 +1124,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}"
PR_LABELS: "${{ needs.build-info.outputs.pullRequestLabels }}"
- name: "Upload KinD logs"
uses: actions/upload-artifact@v2
if: failure()
if: failure() || cancelled()
with:
name: >
kind-logs-KubernetesExecutor
Expand Down

0 comments on commit 4f1e66d

Please sign in to comment.