Cache Hook when initializing CloudFormationCreateStackSensor
#14638
Conversation
- `CloudFormationCreateStackSensor` created `AWSCloudFormationHook` in its init method - This commit delays creation of hook until it is needed
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
| try: | ||
| from functools import cached_property | ||
| except ImportError: | ||
| from cached_property import cached_property |
There was a problem hiding this comment.
Is there a reason why we need both imports?
There was a problem hiding this comment.
If this is an issue then we probably should fix all other operators that use from cached_propert, WDYT?
There was a problem hiding this comment.
Yup, like Elad mentioned #14606 removed the dep for Python 3.8 users. this just build on top of that
CloudFormationCreateStackSensorcreatedAWSCloudFormationHookin its init method^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.