Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in cached_property on Python 3.8 where possible #14606

Merged
merged 2 commits into from
Mar 6, 2021

Conversation

ashb
Copy link
Member

@ashb ashb commented Mar 4, 2021

Functionality is the same, this just removes one dep for Py 3.8+


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Functionality is the same, this just removes one dep for Py 3.8+
@boring-cyborg boring-cyborg bot added area:dev-tools provider:cncf-kubernetes Kubernetes provider related issues area:logging area:secrets provider:amazon-aws AWS/Amazon - related issues provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Mar 4, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@ashb ashb closed this Mar 4, 2021
@ashb ashb reopened this Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@ashb ashb removed area:dev-tools provider:cncf-kubernetes Kubernetes provider related issues area:logging area:secrets provider:amazon-aws AWS/Amazon - related issues provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Mar 5, 2021
@kaxil kaxil merged commit e7bb17a into apache:master Mar 6, 2021
@kaxil kaxil deleted the use-builtin-cached-property branch March 6, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants