-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade rule to check for mesos executor and flag to change it. #11528
Add upgrade rule to check for mesos executor and flag to change it. #11528
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
b6b77f0
to
9058983
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
@mik-laj @turbaszek Could you please take a look? Thanks |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*. |
@mik-laj can you please take a look at CI? This look like a problem with building docs - but not related to the PR? |
@mik-laj Could you please check this PR? Thanks. |
@RaviTezu would you mind rebasing and changing the target base due to #11719 (comment) |
6bf7062
to
a4aa727
Compare
@turbaszek Pulled (with --rebase) commits from |
@RaviTezu sorry for not being clear, you should not only change the target for |
1a5167d
to
382ed24
Compare
@turbaszek No worries. Rebased and force pushed. |
@turbaszek If this looks good to you. Could you please merge the PR? Thanks. |
382ed24
to
fe50f67
Compare
@RaviTezu I cleaned up the PR, once the CI is green I will merge it |
Thank you @turbaszek |
@turbaszek I looked at the failing checks and they seem to be either the CI/CD system related issues or some other test seems to be failing. build errors:
Tests failing:
|
fe50f67
to
dbca38f
Compare
Linked to #11391 |
Awesome work, congrats on your first merged pull request! |
…pache#11528) * add upgrade rule to check for mesos config and flag to remove it. * change from checking the mesos config section to core/executor config * remove leading new line and indent in desc (cherry picked from commit 6739b53)
closes: #11043