Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade rule to check for mesos executor and flag to change it. #11528

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

RaviTezu
Copy link

closes: #11043

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 14, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@RaviTezu RaviTezu changed the title Add upgrade rule to check for mesos config and flag to remove it. Add upgrade rule to check for mesos executor and flag to change it. Oct 15, 2020
@RaviTezu
Copy link
Author

RaviTezu commented Oct 15, 2020

@mik-laj @turbaszek Could you please take a look? Thanks

@mik-laj mik-laj added the area:upgrade Facilitating migration to a newer version of Airflow label Oct 19, 2020
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@turbaszek
Copy link
Member

@mik-laj can you please take a look at CI? This look like a problem with building docs - but not related to the PR?

@RaviTezu
Copy link
Author

@mik-laj Could you please check this PR? Thanks.

@turbaszek
Copy link
Member

@RaviTezu would you mind rebasing and changing the target base due to #11719 (comment)

@RaviTezu RaviTezu changed the base branch from v1-10-test to v1-10-stable October 25, 2020 12:05
@RaviTezu
Copy link
Author

@turbaszek Pulled (with --rebase) commits from v1-10-test into my branch and then changed the base to v1-10-stable. There was a merge conflict and I resolved it.

@turbaszek
Copy link
Member

@RaviTezu sorry for not being clear, you should not only change the target for v1-10-stable but also rebase on this branch. Sorry for inconvenience

@RaviTezu
Copy link
Author

RaviTezu commented Oct 25, 2020

@turbaszek No worries. Rebased and force pushed.

@RaviTezu
Copy link
Author

@turbaszek If this looks good to you. Could you please merge the PR? Thanks.

@turbaszek
Copy link
Member

@RaviTezu I cleaned up the PR, once the CI is green I will merge it

@RaviTezu
Copy link
Author

Thank you @turbaszek

@RaviTezu
Copy link
Author

@turbaszek I looked at the failing checks and they seem to be either the CI/CD system related issues or some other test seems to be failing.

build errors:

{"success":false,"error":400,"message":"Trouble uploading file"}###########################################################################################
                   EXITING /opt/airflow/scripts/ci/in_container/run_ci_tests.sh WITH STATUS CODE 1

Tests failing:

test_scheduler_run_duration
tests/executors/test_dask_executor.py::DaskExecutorTest::test_backfill_integration

@potiuk
Copy link
Member

potiuk commented Nov 3, 2020

Linked to #11391

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 20, 2020

Awesome work, congrats on your first merged pull request!

kaxil pushed a commit that referenced this pull request Nov 20, 2020
…11528)

* add upgrade rule to check for mesos config and flag to remove it.

* change from checking the mesos config section to core/executor config

* remove leading new line and indent in desc

(cherry picked from commit 6739b53)
kaxil pushed a commit that referenced this pull request Nov 21, 2020
…11528)

* add upgrade rule to check for mesos config and flag to remove it.

* change from checking the mesos config section to core/executor config

* remove leading new line and indent in desc

(cherry picked from commit 6739b53)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
…pache#11528)

* add upgrade rule to check for mesos config and flag to remove it.

* change from checking the mesos config section to core/executor config

* remove leading new line and indent in desc

(cherry picked from commit 6739b53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:upgrade Facilitating migration to a newer version of Airflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create MesosExecutorRemovedRule to ease upgrade to Airflow 2.0
5 participants