-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MesosExecutorRemovedRule to ease upgrade to Airflow 2.0 #11043
Comments
Hi @turbaszek I would like to take this up. Could you please assign this to me? Thanks. |
Thanks @turbaszek |
@RaviTezu Yes. Mesos may be added after the release Airflow 2.0, as we are now focusing on this release and prioritizing the tasks that are related to this release. Adding new features that are not in the roadmap is not essential now, so it may be a bit slower. Additionally, few core contributors have experience with Mesos, so there is a chance that there will be a problem with the reviewer. That being said, we should work as planned and add a migration alert. |
Thanks for the reply @mik-laj 👍 |
@mik-laj @turbaszek Just want to confirm what needs to be done:
Thanks. |
@turbaszek @RaviTezu can we close this ticket? |
@dimberman Yes. I think, it can be closed. |
Done in #11528, thanks! |
This issue is part of #8765
Rule
Create
MesosExecutorRemovedRule
which corresponds toentry in UPDATING.md. This rule should allow users to check if their current configuration needs any adjusting
before migration to Airflow 2.0.
How to guide
To implement a new rule, create a class that inherits from
airflow.upgrade.rules.base_rule.BaseRule
.It will be auto-registered and used by
airflow upgrade-check
command. The custom rule class has to havetitle
,description
properties and should implementcheck
method which returns a list of error messages in case ofincompatibility.
For example:
airflow/airflow/upgrade/rules/conn_type_is_not_nullable.py
Lines 25 to 42 in ea36166
Remember to open the PR against
v1-10-test
branch.The text was updated successfully, but these errors were encountered: