Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type check for multiple providers #11229

Merged
merged 10 commits into from
Oct 2, 2020
Merged

Strict type check for multiple providers #11229

merged 10 commits into from
Oct 2, 2020

Conversation

mlgruby
Copy link
Contributor

@mlgruby mlgruby commented Oct 1, 2020

Strict type check for multiple providers. Part of: #9708
cc: @kaxil @mik-laj tried covering all smaller provider, can I request for review?

Only big ones are left (Microsft, AWS and Google) and also we need to do strict type check for dbapi_hook.py as lots of
providers are extending this one and there are functions whose types/signature is not defined.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mlgruby
Copy link
Contributor Author

mlgruby commented Oct 1, 2020

42.599590 amazon
52.078754 microsoft
69.100860 google
75.000000 postgres
77.619050 databricks
80.625000 ftp
82.449500 cncf
83.333300 odbc
83.333300 openfaas
87.421875 apache
87.500000 presto ==========> from 0 to 87
87.500000 redis
88.333340 mysql
88.888900 papermill
90.178575 slack ===========> from 77 to 90
90.909100 elasticsearch
94.532960 qubole ==========> from 0 to 94
96.428575 salesforce
96.875000 mongo
98.076900 imap
100.000000 celery
100.000000 cloudant
100.000000 datadog
100.000000 dingding =======> from 0 to 100
100.000000 discord
100.000000 docker
100.000000 exasol
100.000000 facebook
100.000000 grpc
100.000000 hashicorp
100.000000 http
100.000000 jdbc
100.000000 jenkins
100.000000 jira
100.000000 opsgenie =======> from 0 to 100
100.000000 oracle
100.000000 pagerduty
100.000000 plexus
100.000000 samba ==========> from 0 to 100
100.000000 segment
100.000000 sendgrid
100.000000 sftp
100.000000 singularity
100.000000 snowflake
100.000000 sqlite
100.000000 ssh
100.000000 vertica
100.000000 yandex
100.000000 zendesk ========> from 0 to 100

@mik-laj
Copy link
Member

mik-laj commented Oct 1, 2020

I am very glad that you are working on typing coverage for providers. This will make life easier for many users as type problems can be detected much earlier.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kaxil kaxil merged commit 720912f into apache:master Oct 2, 2020
@mlgruby mlgruby deleted the gruby-dev-static-type branch October 15, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants