Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(legacy-plugin-chart-country-map): fix Iran country map #1358 #1359

Closed
wants to merge 1 commit into from
Closed

fix(legacy-plugin-chart-country-map): fix Iran country map #1358 #1359

wants to merge 1 commit into from

Conversation

mohsen-eng74
Copy link

Hello,

both ISO 3166-2 and geometry of the provinces of Iran are outdated. i've checked the Natural Earth Data source, but still not valid.

  • The valid geometry of the provinces is taken from the OpenStreetMap with some modification (symmetric difference applied to get the land border). also, OpenStreetMap geometry is more compatible with approved provincial map by the Ministry of Interior of the Islamic Republic of Iran.
  • the valid ISO 3166-2 is taken from iso.org.

With Best Regards.

@mohsen-eng74 mohsen-eng74 requested a review from a team as a code owner September 12, 2021 06:59
@vercel
Copy link

vercel bot commented Sep 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/CsXqfsm2uTrt4Dtuz59pJyvS2n8a
✅ Preview: https://superset-ui-git-fork-mohsen-eng74-fix-iran-coun-e637bf-superset.vercel.app

@mohsen-eng74
Copy link
Author

mohsen-eng74 commented Sep 12, 2021

it seems that it has an issue (doesn't show the map correctly), but don't know the reason!

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:

  • core packages: packages/** (this repo) -> superset-frontend/packages/** (main repo)
  • plugins: plugins/** (this repo) -> superset-frontend/plugins/** (main repo)

If you need help with the migration, please post a message on the SIP or reach out on the community Slack.

@villebro villebro closed this Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants