Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Spotify naming #256

Merged
merged 2 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spotify_player/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.15.0"
authors = ["Thang Pham <[email protected]>"]
edition = "2021"
license = "MIT"
description = "A command driven spotify player"
description = "A command driven Spotify player"
jacksongoode marked this conversation as resolved.
Show resolved Hide resolved
repository = "https://github.com/aome510/spotify-player"
keywords = ["spotify", "tui", "player"]
readme = "../README.md"
Expand Down
2 changes: 1 addition & 1 deletion spotify_player/src/cli/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ async fn handle_get_key_request(client: &Client, state: &SharedState, key: Key)

/// Get a Spotify item's ID from its `IdOrName` representation
async fn get_spotify_id(client: &Client, typ: ItemType, id_or_name: IdOrName) -> Result<ItemId> {
// For `IdOrName::Name`, we search for the first item matching the name and return its spotify id.
// For `IdOrName::Name`, we search for the first item matching the name and return its Spotify id.
// The item's id is then used to retrieve the item's data.

let sid = match typ {
Expand Down
2 changes: 1 addition & 1 deletion spotify_player/src/cli/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub fn init_connect_subcommand() -> Command {

pub fn init_get_subcommand() -> Command {
Command::new("get")
.about("Get spotify data")
.about("Get Spotify data")
.subcommand_required(true)
.subcommand(
Command::new("key").about("Get data by key").arg(
Expand Down
2 changes: 1 addition & 1 deletion spotify_player/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ impl Default for AppConfig {
fn default() -> Self {
Self {
theme: "dracula".to_owned(),
// official spotify web app's client id
// official Spotify web app's client id
client_id: "65b708073fc0480ea92a077233ca87bd".to_string(),

client_port: 8080,
Expand Down
6 changes: 3 additions & 3 deletions spotify_player/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fn init_app_cli_arguments() -> Result<clap::ArgMatches> {

let cmd = clap::Command::new("spotify_player")
.version("0.15.0")
.about("A command driven spotify player")
.about("A command driven Spotify player")
jacksongoode marked this conversation as resolved.
Show resolved Hide resolved
.author("Thang Pham <phamducthang1234@gmail>")
.subcommand(cli::init_get_subcommand())
.subcommand(cli::init_playback_subcommand())
Expand Down Expand Up @@ -183,7 +183,7 @@ async fn start_app(state: state::SharedState, is_daemon: bool) -> Result<()> {
let auth_config = auth::AuthConfig::new(&state)?;
let session = auth::new_session(&auth_config, !is_daemon).await?;

// create a spotify API client
// create a Spotify API client
let client = client::Client::new(
session,
auth_config,
Expand All @@ -195,7 +195,7 @@ async fn start_app(state: state::SharedState, is_daemon: bool) -> Result<()> {
// initialize Spotify-related stuff
init_spotify(&client_pub, &client, &state, is_daemon)
.await
.context("failed to initialize the spotify data")?;
.context("Failed to initialize the Spotify data")?;

// Spawn application's tasks
let mut tasks = Vec::new();
Expand Down
Loading