Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent Spotify naming #256

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Consistent Spotify naming #256

merged 2 commits into from
Sep 20, 2023

Conversation

jacksongoode
Copy link
Contributor

@jacksongoode jacksongoode commented Sep 20, 2023 •
edited
Loading

There might be other small naming consistency fixes but this is just for Spotify.

I would also change the repo description from:

A terminal spotify player that is feature parity with the official client

to

A Spotify player in the terminal with full feature parity.

as the original phrasing is a bit awkward? Just my suggestion.

aome510
aome510 requested changes Sep 20, 2023
View reviewed changes
spotify_player/Cargo.toml Outdated Show resolved Hide resolved
spotify_player/src/main.rs Outdated Show resolved Hide resolved
@aome510
Copy link
Owner

aome510 commented Sep 20, 2023

I would also change the repo description from:

A terminal spotify player that is feature parity with the official client

to

A Spotify player in the terminal with full feature parity.

as the original phrasing is a bit awkward? Just my suggestion.

Thanks for the suggestion. Updated

@aome510 aome510 merged commit 05fbda6 into aome510:master Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aome510 aome510 aome510 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacksongoode @aome510