SecretsのDOCKERHUB_USERNAMEをVariablesに移行する (VOICEVOX#667)

aoirint · Apr 17, 2023 · e529ce6 · e529ce6
1 parent dbbd0ca
commit e529ce6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/.github/workflows/build-docker.yml b/.github/workflows/build-docker.yml
@@ -13,7 +13,7 @@ on:
         required: true
 
 env:
-  IMAGE_NAME: ${{ secrets.DOCKERHUB_USERNAME }}/voicevox_engine
+  IMAGE_NAME: ${{ vars.DOCKERHUB_USERNAME }}/voicevox_engine
   PYTHON_VERSION: "3.11.3"
   VOICEVOX_RESOURCE_VERSION: "0.14.2"
   VOICEVOX_CORE_VERSION: "0.14.3"
@@ -90,7 +90,7 @@ jobs:
       - name: Login to DockerHub
         uses: docker/login-action@v2
         with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          username: ${{ vars.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       # Download VOICEVOX RESOURCE
@@ -153,4 +153,4 @@ jobs:
     uses: ./.github/workflows/release-test-docker.yml
     with:
       version: ${{ needs.config.outputs.version }}
-      repo_url: ${{ format('{0}/{1}', github.server_url, github.repository) }} # このリポジトリのURL
+      repo_url: ${{ format('{0}/{1}', github.server_url, github.repository) }} # このリポジトリのURL
diff --git a/.github/workflows/release-test-docker.yml b/.github/workflows/release-test-docker.yml
@@ -17,7 +17,7 @@ on:
         required: true
 
 env:
-  IMAGE_NAME: ${{ secrets.DOCKERHUB_USERNAME }}/voicevox_engine
+  IMAGE_NAME: ${{ vars.DOCKERHUB_USERNAME }}/voicevox_engine
   VERSION: |- # version指定時はversionを、それ以外はタグ名を使用
     ${{ (github.event.inputs || inputs).version }}
 

diff --git a/README.md b/README.md
@@ -548,11 +548,16 @@ VOICEVOX エディターにうまく読み込ませられないときは、エ
 
 ## GitHub Actions
 
-### Secrets
+### Variables
 
 | name               | description                                                             |
 | :----------------- | :---------------------------------------------------------------------- |
 | DOCKERHUB_USERNAME | Docker Hub ユーザ名                                                     |
+
+### Secrets
+
+| name               | description                                                             |
+| :----------------- | :---------------------------------------------------------------------- |
 | DOCKERHUB_TOKEN    | [Docker Hub アクセストークン](https://hub.docker.com/settings/security) |
 
 ## 事例紹介