Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecretsのDOCKERHUB_USERNAMEをVariablesに移行する #667

Merged
merged 4 commits into from
Apr 17, 2023

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Apr 16, 2023

内容

CIで使用するDocker Hubのユーザ名の参照先をSecretsからVariables(構成変数)に変更します。

Fork先リポジトリでDockerイメージのリリースをしている場合、Variablesの設定が必要です。

また、Secretsから既存のDOCKERHUB_USERNAMEを削除することで、CIのログでDOCKERHUB_USERNAMEがマスクされなくなるほか、リリースタグ名にDOCKERHUB_USERNAMEを含む文字列が使用できるようになります。

動作確認用CI: https://github.com/aoirint/voicevox_engine/actions/runs/4710416790

関連 Issue

スクリーンショット・動画など

その他

@github-actions
Copy link

github-actions bot commented Apr 16, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 2 1 coverage-50%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 3 1 coverage-67%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 14 coverage-52%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 150 9 coverage-94%
voicevox_engine/mora_list.py 5 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 3 1 coverage-67%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 159 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 9 2 coverage-78%
voicevox_engine/utility/mutex_utility.py 11 1 coverage-91%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 1413 284 coverage-80%

@aoirint aoirint marked this pull request as ready for review April 16, 2023 00:27
@aoirint aoirint requested a review from a team as a code owner April 16, 2023 00:27
@aoirint aoirint requested review from y-chan and removed request for a team April 16, 2023 00:27
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba
Copy link
Member

横からすみません! コンフリクトが発生してしまってそうでした

@aoirint
Copy link
Member Author

aoirint commented Apr 17, 2023

コンフリクト解消しました!

(1行下に変更があったから...?)

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします!!

@Hiroshiba Hiroshiba merged commit e529ce6 into VOICEVOX:master Apr 17, 2023
@aoirint aoirint deleted the patch-vars-dockerhub-username branch October 9, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SecretsのDOCKERHUB_USERNAMEをVariablesに移行する
3 participants