-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecretsのDOCKERHUB_USERNAMEをVariablesに移行する #667
Merged
Hiroshiba
merged 4 commits into
VOICEVOX:master
from
aoirint:patch-vars-dockerhub-username
Apr 17, 2023
Merged
SecretsのDOCKERHUB_USERNAMEをVariablesに移行する #667
Hiroshiba
merged 4 commits into
VOICEVOX:master
from
aoirint:patch-vars-dockerhub-username
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
横からすみません! コンフリクトが発生してしまってそうでした |
コンフリクト解消しました! (1行下に変更があったから...?) |
問題ないと思うのでマージします!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
CIで使用するDocker Hubのユーザ名の参照先をSecretsからVariables(構成変数)に変更します。
Fork先リポジトリでDockerイメージのリリースをしている場合、Variablesの設定が必要です。
また、Secretsから既存の
DOCKERHUB_USERNAME
を削除することで、CIのログでDOCKERHUB_USERNAME
がマスクされなくなるほか、リリースタグ名にDOCKERHUB_USERNAME
を含む文字列が使用できるようになります。動作確認用CI: https://github.com/aoirint/voicevox_engine/actions/runs/4710416790
関連 Issue
スクリーンショット・動画など
その他