-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change network #328
Change network #328
Conversation
Network UI react
Change network: react-ui
update react-ui starter project
Check react-ui starter project on how to use the new |
Network Button Added
@jordansexton could you take a look at this PR? |
@jordansexton and @tyirenkyi how close is this to being merged? We have a network selector in our app, and i'm trying to start using the wallet-adapter for it too, and this is the last weird sync area :D |
Not at all close. I wouldn't count on it landing, and it's not a high priority. If you need network selection, better to implement in your app. |
mmmm, darn :) thanks. |
Closing as we probably won't implement this at the application or adapter level. We will soon move away from requiring adapters for every wallet, and the new wallet standard will have a network param in the relevant methods. |
Folks, could you point me to the new wallet standard? We have several applications deploying with custom RPCs, and while we could create a new standard so they can support this feature to change networks, we'd prefer to adopt what y'all already have in mind. It is cited as one of the most popular pain points for us. It sounds like Backpack and Solflare are on board to implement whatever is needed on their end if we can surface the relevant information via the wallet adapter or however else. |
@neelsomani https://github.com/solana-labs/wallet-standard/tree/master/packages/core/features is where this would likely go. Please open an issue on that repo before sending a PR though. For context, Backpack currently implements this as We've avoided dependency on web3.js across the Wallet Standard, using raw bytes everywhere instead of web3.js types. Also consider that web3.js is getting a planned rewrite. |
This PR aims to add the change network feature mentioned in #46.
What's been done:
What's being worked on: