Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionProvider doesn't allow changing connection end point #149

Closed
leofisG opened this issue Oct 28, 2021 · 3 comments
Closed

ConnectionProvider doesn't allow changing connection end point #149

leofisG opened this issue Oct 28, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@leofisG
Copy link
Contributor

leofisG commented Oct 28, 2021

Is your feature request related to a problem? Please describe.
We cannot change the end point that passed into ConnectionProvider.

Describe the solution you'd like
A clear and concise description of what you want to happen.

export interface ConnectionProviderProps {
    children: ReactNode;
    endpoint: string;
    config?: ConnectionConfig;
    setEndpoint: (endpoint: string) => void;
}

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@leofisG
Copy link
Contributor Author

leofisG commented Oct 28, 2021

I can send in a PR if interested.

@jordaaash
Copy link
Collaborator

This is partially implemented here: #105

This PR was reviewed and needs some changes, but feel free to use it as a basis for your own PR if you like!

@jordaaash jordaaash added enhancement New feature or request good first issue Good for newcomers labels Nov 3, 2021
@jordaaash jordaaash added icebox Come back to this later and removed icebox Come back to this later labels Feb 6, 2022
@jordaaash
Copy link
Collaborator

Closing this as stale, but potentially will be implemented in #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants