Feature: Connection switch #105
Conversation
|
|
||
| export function useSetConnection(): (connection: Connection) => void { | ||
| const dispatch = useContext(ConnectionDispatchContext); | ||
| return (connection: Connection) => dispatch(connection); | ||
| } |
There was a problem hiding this comment.
This seems overly complicated. Why not just const [connection, setConnection] = useState(() => new Connection(...)) in the provider and then pass setConnection into the context?
| endpoint: clusterApiUrl(WalletAdapterNetwork.Mainnet), | ||
| name: 'Mainnet', | ||
| }, | ||
| { | ||
| endpoint: clusterApiUrl(WalletAdapterNetwork.Devnet), | ||
| name: 'Devnet', | ||
| }, | ||
| { | ||
| endpoint: clusterApiUrl(WalletAdapterNetwork.Testnet), | ||
| name: 'Testnet', |
There was a problem hiding this comment.
Names like this should be an enum or some other typesafe structure so that child components are sure to input the correct values. The connections array could be part of the ConnectionProvider since it's not dependent upon UI, and the connection value can be an item in that array.
| connection: { | ||
| name: string; | ||
| }; |
There was a problem hiding this comment.
This should be a named interface provided by the context.
| connections: { | ||
| name: string; | ||
| endpoint: string; | ||
| }[]; |
There was a problem hiding this comment.
Always good to export named interfaces for nested props if they need to be consumed by descendants and downstream devs.
| } | ||
| ) => { | ||
| // TODO: Add a way to replace commitment. | ||
| setConnection(new Connection(connection.endpoint, { commitment: 'confirmed' })); |
There was a problem hiding this comment.
I'm not sure why this doesn't use the connection options provided by the existing ConnectionProvider context.
| import { WalletConnectButton } from './WalletConnectButton'; | ||
| import { WalletIcon } from './WalletIcon'; | ||
| import { WalletModalButton } from './WalletModalButton'; | ||
|
|
||
| export const WalletMultiButton: FC<ButtonProps> = ({ type = 'primary', size = 'large', children, ...props }) => { | ||
| const { publicKey, wallet, disconnect } = useWallet(); | ||
| const { setVisible } = useWalletModal(); | ||
| const { setVisible: setConnetionModalVisible } = useConnectionModal(); |
|
Closing for now since there's been no response. Please comment if you want to reopen! |
This feature enables switching the connection.
Draft PR. Additional implementations on the way.