quic: delay calling set_max_concurrent_uni_streams/set_receive_window #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oing to drop a connection Avoids taking a mutex and waking a task.
alessandrod
force-pushed
the
quic-uni-streams-later
branch
from
01c457a to
d5a73f9
Compare
alessandrod
changed the title
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 853 853
Lines 231776 231779 +3
=========================================
- Hits 189871 189854 -17
- Misses 41905 41925 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
…#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs
alessandrod
added a commit
that referenced
this pull request
Apr 24, 2024
…#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs
lijunwangs
pushed a commit
that referenced
this pull request
Apr 24, 2024
…_window (backport of #904) (#968) quic: delay calling set_max_concurrent_uni_streams/set_receive_window (#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) Co-authored-by: Alessandro Decina <[email protected]>
alessandrod
added a commit
that referenced
this pull request
Apr 24, 2024
…#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs
alessandrod
added a commit
that referenced
this pull request
Apr 25, 2024
…#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs
t-nelson
pushed a commit
that referenced
this pull request
Apr 30, 2024
…_window (backport of #904) (#967) * quic: delay calling set_max_concurrent_uni_streams/set_receive_window (#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) # Conflicts: # streamer/src/nonblocking/quic.rs * Fix merge conflicts --------- Co-authored-by: Alessandro Decina <[email protected]>
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…_window (backport of anza-xyz#904) (anza-xyz#968) quic: delay calling set_max_concurrent_uni_streams/set_receive_window (anza-xyz#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) Co-authored-by: Alessandro Decina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay calling connection.set_max_concurrent_uni_streams() and connection.set_receive_window() to when we know we've accepted the connection. Avoids a short window where the peer could start transmitting even if we're going to drop the connection, and avoids taking the connection mutex and waking a task.